[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] bridge_driver: Don't define network if XML contains more IPv4 adreses.



On 11/30/2011 07:39 AM, Peter Krempa wrote:
> Only one IPv4 DHCP definition is supported. Originaly the code checked

s/Originaly/Originally/

> for a multiple definition and returned an error, but the new domain
> definition was already added to networks. This patch moves the check
> before the newly defined network is added to active networks.
> 
>  *src/network/bridge_driver.c: networkDefine(): - move multiple IPv4
>                                                   adresses check before

s/adresses/addresses/

>                                                   definition is used.
> ---
>  src/network/bridge_driver.c |   29 +++++++++++++++--------------
>  1 files changed, 15 insertions(+), 14 deletions(-)
> 
> -    if (ipv4def) {
...
> +
> +   if (ipv4def) {

Spurious indentation change.

ACK with that and the typos in the commit message fixed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]