[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/6] qemu: Plug memory leak onqemuProcessWaitForMonitor() error path



On 11/29/2011 11:49 PM, ajia redhat com wrote:
> From: Alex Jia <ajia redhat com>
> 
> Detected by Coverity. Leak introduced in commit 109efd7.
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  src/qemu/qemu_process.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 2563f97..b05c280 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -1224,7 +1224,7 @@ qemuProcessWaitForMonitor(struct qemud_driver* driver,
>  
>          if (VIR_ALLOC_N(buf, buf_size) < 0) {
>              virReportOOMError();
> -            return -1;
> +            goto closelog;

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]