[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Comment inconsistency in bridge_driver.c



On Mon, Oct 03, 2011 at 09:16:28AM +0100, Neil Wilson wrote:
> Hi,
> 
> At line 1560 in srv/network/bridge_driver.c it says:
> 
>   /* All interfaces used as a gateway (which is what this is, by
>      * definition), must always have autoconf=0.
>      */
> 
> and then promptly sets that variable to 1 with
> 
>    if (virFileWriteStr(field, "1", 0) < 0) {
> 
> 
> Is the comment or the code the correct value?

I believe the code is incorrect.  Any interface which is to act
as an IPv6 router must have autoconf set to 0.  IIRC, if you run
the radvd daemon on an interface, it will force that interface to
have autoconf=0.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]