[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Allow passing of command line args to LXC container



On 10/03/2011 11:40 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange redhat com>

When booting a virtual machine with a kernel/initrd it is possible
to pass command line arguments using the<cmdline>...args...</cmdline>
element in the guest XML. These appear to the kernel / init process
in /proc/cmdline.

When booting a container we do not have a custom /proc/cmdline,
but we can easily set an environment variable for it. Ideally
we could pass individual arguments to the init process as a
regular set of 'char *argv[]' parameters, but that would involve
libvirt parsing the<cmdline>  XML text. This can easily be added
later, even if we add the env variable now

* docs/drvlxc.html.in: Document env variables passed to LXC
* src/conf/domain_conf.c: Add<cmdline>  to be parsed for
   guests of type='exe'
* src/lxc/lxc_container.c: Set LIBVIRT_LXC_CMDLINE env var
---
  docs/drvlxc.html.in     |   17 +++++++++++++++++
  src/conf/domain_conf.c  |    1 +
  src/lxc/lxc_container.c |    2 ++
  3 files changed, 20 insertions(+), 0 deletions(-)

ACK, and agreed about the potential for future argv parsing improvement being deferred to a later patch.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]