[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH] lxc: don't return error on GetInfo when cgroups not yet set up



On Mon, Oct 03, 2011 at 02:03:18PM -0500, Serge E. Hallyn wrote:
> Quoting Daniel P. Berrange (berrange redhat com):
> > The LXC controller 'main' method received the handshake FD and invokes
> > lxcControllerRun(). This method does various setup tasks, in particular
> > the following:
> > 
> > 
> >     ....
> >     if (lxcSetContainerResources(def) < 0)
> >         goto cleanup;
> >     ...
> ...
> >     if (lxcContainerSendContinue(handshakefd) < 0) {
> >         virReportSystemError(errno, "%s",
> >                              _("error sending continue signal to parent"));
> >         goto cleanup;
> >     }
> >     VIR_FORCE_CLOSE(handshakefd);
> 
> Thanks, Daniel.  You're right!  This is fixed in git, by the patch 'lxc:
> controller: Improve container error reporting' (which does much more
> than it says :).  The following patch is how I had just fixed 0.9.2 this
> morning.  It'll be nicer if I can get the git commit cherrypicked.  I
> can't wait till I can upgrade!

Ahhhhh, that explains it :-) Good to know its fixed then.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]