[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't fail virDomainGetInfo if we can't update balloon info



On Wed, Oct 05, 2011 at 08:22:51 -0600, Eric Blake wrote:
> On 10/05/2011 08:17 AM, Jiri Denemark wrote:
> > Qemu driver tries to update balloon data in virDomainGetInfo and if it
> > can't do so because there is another monitor job running, it just
> > reports what's known in domain def. However, if there was no job running
> > but getting the data from qemu fails, we would fail the whole API. This
> > doesn't make sense. Let's make the failure nonfatal.
> > ---
> >   src/qemu/qemu_driver.c |   13 +++++++++----
> >   1 files changed, 9 insertions(+), 4 deletions(-)
> 
> ACK.  And thanks for the extra context; it made reviewing easier.

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]