[libvirt] [PATCHv2 12/7] snapshot: implement snapshot roots listing in esx

[Eric Blake]

On 10/05/2011 02:46 AM, Matthias Bolte wrote:
> You probably meant vbox and not esx in the subject, didn't you?

Yep, noticed that just after I sent the mail.

>
> 2011/10/4 Eric Blake<eblake at redhat.com>:
>> Commit 9f5e53e introduced the ability to filter snapshots to
>> just roots, but it was never implemented for VBox until now.
>> The VBox documentation makes it appear that there can only be
>> at most one root snapshot, which will be found by searching
>> for the snapshot with a NULL uuid.
>>

> There's a trick, VBox doesn't allow you to delete a snapshot with more
> than one child. So you can never create a situation with multiple
> roots.

Useful to know.  I've updated the commit message accordingly.

>
>>   src/vbox/vbox_tmpl.c |   37 ++++++++++++++++++++++++++++++++-----
>>   1 files changed, 32 insertions(+), 5 deletions(-)
>
> Tested (but only on VBox 4.0), works, ACK.

I've gone ahead and pushed this one.  I'll resubmit a v2 of 11/7 which 
takes into account your findings.  Meanwhile, 13/7 depends on the API 
addition in 1/7 being reviewed first.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org