[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix deadlock when the RPC program is unknown



On 06.10.2011 11:43, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Commit 597fe3cee68f561a181967b59a87b4e5c5880c4c accidentally
> introduced a deadlock when reporting an unknown RPC program.
> The virNetServerDispatchNewMessage method is called with
> the client locked, and must therefore not attempt to send
> any RPC messages back to the client. Only once the incoming
> message is passed off to the virNetServerHandleJob worker
> is it safe to start sending messages back
> 
> * src/rpc/virnetserver.c: Delay checking for unknown RPC
>   program until in worker thread
> ---
>  src/rpc/virnetserver.c |   22 ++++++++++++++--------
>  1 files changed, 14 insertions(+), 8 deletions(-)
> 

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]