[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't send back unknown program errors for async messages



On 10/06/2011 04:10 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange redhat com>

If we send back an unknown program error for async messages,
we will confuse the client because they only expect replies
for method calls. Just log&  drop any invalid async messages

* src/rpc/virnetserver.c: Don't send error for async messages
---
  src/rpc/virnetserver.c        |   23 +++++++++++++++++++----
  src/rpc/virnetserverprogram.c |   13 ++++++++++++-
  2 files changed, 31 insertions(+), 5 deletions(-)

ACK.

+        } else {
+            VIR_INFO("Dropping client mesage, unknown program %d version %d type %d proc %d",

s/mesage/message/

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]