[libvirt] [PATCH 1.5/2] qemu: leave rerror policy at default when enospace is requested

[Eric Blake]

On 10/05/2011 09:06 PM, Laine Stump wrote:
> commit 12062ab set rerror=ignore when error_policy="enospace" was
> selected (since the rerror option in qemu doesn't accept "enospc", as
> the werror option does).
>
> After that patch was already pushed, Paolo Bonzini noticed it and
> commented that leaving rerror at the default ("report") would be a
> better choice. This patch corrects the problem - if error_policy =
> "enospace" is given, rerror is left off the qemu commandline,
> effectively setting it to "report". For other values, rerror is still
> set to match werror.
>
> Additionally, the parsing of error_policy was changed to no longer
> erroneously allow "default" as a choice - as with most other
> attributes, if you want the default setting, just don't specify an
> error_policy.
>
> Finally, two ommissions in the first patch were corrected - a

s/ommissions/omissions/

> long-dormant qemuxml2argv test for enospace was enabled, and fixed to
> pass, and the argv2xml parser in qemu_command.c was updated to
> recognize the different spelling on the qemu commandline.
> ---
>   src/conf/domain_conf.c                             |    2 +-
>   src/qemu/qemu_command.c                            |   15 ++++++++-------
>   ...uxml2argv-disk-drive-error-policy-enospace.args |    2 +-
>   tests/qemuxml2argvtest.c                           |    2 ++
>   4 files changed, 12 insertions(+), 9 deletions(-)
>

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org