[libvirt] [PATCH] remote_driver: Avoid double free in EventControl building
Eric Blake
eblake at redhat.com
Thu Oct 6 18:43:18 UTC 2011
On 10/06/2011 07:41 AM, Michal Privoznik wrote:
> Don't xdr_free event data as they are freed by our caller
> virNetClientProgramDispatch.
> ---
> src/remote/remote_driver.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 83f4f3c..2b2f41e 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -3315,7 +3315,6 @@ remoteDomainBuildEventControlError(virNetClientProgramPtr prog ATTRIBUTE_UNUSED,
> return;
>
> event = virDomainEventControlErrorNewFromDom(dom);
> - xdr_free ((xdrproc_t)&xdr_remote_domain_event_control_error_msg, (char *)&msg);
ACK - matches that mgs was assigned to evdata passed in as parameter
rather than allocated here in remoteDomainBuildEventControlError.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list