[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/3] Don't use empty message when building a GError



On Thu, Oct 06, 2011 at 08:24:10PM +0200, Christophe Fergeau wrote:
> After testing that 'message' is NULL, gvir_error_new_literal
> is using it to build a GError. What was meant was to use
> verr->message.
> ---
>  libvirt-glib/libvirt-glib-error.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libvirt-glib/libvirt-glib-error.c b/libvirt-glib/libvirt-glib-error.c
> index 7afa802..f59b464 100644
> --- a/libvirt-glib/libvirt-glib-error.c
> +++ b/libvirt-glib/libvirt-glib-error.c
> @@ -92,7 +92,7 @@ GError *gvir_error_new_literal(GQuark domain,
>          return g_error_new(domain,
>                             code,
>                             "%s",
> -                           message);
> +                           verr->message);
>  }

ACK to all 3 patches in this series


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]