[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Update the help information for undefine command.



On 10/07/2011 03:34 AM, tangchen wrote:
virsh undefine command can now undefine an active guest, but the help information is still the old.
This patch modifies it and make it coincident to the manpage of virsh.

Signed-off-by: tangchen<tangchen cn fujitsu com>
---
  tools/virsh.c |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 48f2b8a..c3b467e 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1897,8 +1897,10 @@ cmdDefine(vshControl *ctl, const vshCmd *cmd)
   * "undefine" command
   */
  static const vshCmdInfo info_undefine[] = {
-    {"help", N_("undefine an inactive domain")},
-    {"desc", N_("Undefine the configuration for an inactive domain.")},
+    {"help", N_("Undefine a domain, active or inactive.")},
+    {"desc", N_("Undefine a domain. If the domain is running, this converts \n"
+		"    it to a transient domain, without stopping it. If the \n"
+		"    domain is inactive, the domain configuration is removed.")},

Thanks.  This is a bit long, so I shortened it to:

diff --git a/tools/virsh.c b/tools/virsh.c
index 3da8bc5..9532bc3 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1897,8 +1897,9 @@ cmdDefine(vshControl *ctl, const vshCmd *cmd)
  * "undefine" command
  */
 static const vshCmdInfo info_undefine[] = {
-    {"help", N_("undefine an inactive domain")},
-    {"desc", N_("Undefine the configuration for an inactive domain.")},
+    {"help", N_("undefine a domain")},
+    {"desc",
+ N_("Undefine an inactive domain, or convert persistent to transient.")},
     {NULL, NULL}
 };


I also added you to AUTHORS; let me know if I need to adjust that to match your preferred spelling.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]