[libvirt] [PATCH 5/7] Fix missing lock calls on virNetTLSContextRef

Eric Blake eblake at redhat.com
Fri Oct 7 17:44:25 UTC 2011


On 10/07/2011 09:56 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> The virNetTLSContextRef API forgot to acquire/release the lock
> while changing ctxt->refs
>
> * src/rpc/virnettlscontext.c: Add lock calls
> ---
>   src/rpc/virnettlscontext.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
> index 58accaf..f3cc769 100644
> --- a/src/rpc/virnettlscontext.c
> +++ b/src/rpc/virnettlscontext.c
> @@ -931,7 +931,9 @@ virNetTLSContextPtr virNetTLSContextNewClient(const char *cacert,
>
>   void virNetTLSContextRef(virNetTLSContextPtr ctxt)
>   {
> +    virMutexLock(&ctxt->lock);
>       ctxt->refs++;
> +    virMutexUnlock(&ctxt->lock);
>   }

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list