[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/7] Update examples for probing with systemtap

On 10/07/2011 09:56 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange redhat com>

This removes the old example for legacy probes and adds two
new scripts demonstrating many of the new probe point facilities.

The rpc-monitor.stp script will print out friendly detaisl of all


RPC traffic between a libvirt client/server. This is incredibly
useful in seeing what RPC calls are being made, and also debugging
problems in the RPC protocol code

The events.stp script will print out lots of info about the poll
event loop, which is useful for debugging event handling problems

* examples/systemtap/events.stp<  examples/systemtap/rpc-monitor.stp:
   New examples
* examples/systemtap/client.stp: Remove obsolete example
  examples/systemtap/Makefile.am     |    3 +-
  examples/systemtap/client.stp      |   28 -------
  examples/systemtap/events.stp      |  133 ++++++++++++++++++++++++++++++
  examples/systemtap/rpc-monitor.stp |  158 ++++++++++++++++++++++++++++++++++++
  4 files changed, 293 insertions(+), 29 deletions(-)
  delete mode 100644 examples/systemtap/client.stp
  create mode 100644 examples/systemtap/events.stp
  create mode 100644 examples/systemtap/rpc-monitor.stp

+++ b/examples/systemtap/Makefile.am
@@ -1,4 +1,5 @@
  ## Copyright (C) 2005-2011 Red Hat, Inc.
  ## See COPYING.LIB for the License of this software

-EXTRA_DIST = client.stp
+EXTRA_DIST = $(wildcard *.stp)

Does this still work in VPATH builds?

diff --git a/examples/systemtap/events.stp b/examples/systemtap/events.stp
new file mode 100644
index 0000000..b148630
--- /dev/null
+++ b/examples/systemtap/events.stp
@@ -0,0 +1,133 @@

Should this be mode 100755?

\ No newline at end of file

That's worth fixing.

diff --git a/examples/systemtap/rpc-monitor.stp b/examples/systemtap/rpc-monitor.stp
new file mode 100644
index 0000000..b868bf7
--- /dev/null
+++ b/examples/systemtap/rpc-monitor.stp
@@ -0,0 +1,158 @@

Another mode question.

ACK with nits fixed.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]