[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/2] virDomainCoreDump: Introduce VIR_DUMP_RESET flag



On 09/26/2011 10:19 AM, Michal Privoznik wrote:
This flag is intended to allow user to do so called system reset
after dump, instead of sending ACPI reboot event.
---
  include/libvirt/libvirt.h.in |    1 +
  src/libvirt.c                |   15 ++++++++++++++-
  tools/virsh.c                |    3 +++
  tools/virsh.pod              |    4 +++-
  4 files changed, 21 insertions(+), 2 deletions(-)


ACK with one nit:

+++ b/tools/virsh.pod
@@ -629,13 +629,15 @@ Convert the file I<xml>  in domain XML format to the native guest
  configuration format named by I<format>.

  =item B<dump>  I<domain-id>  I<corefilepath>  [I<--live>] [I<--crash>]
-[I<--bypass-cache>]
+[I<--bypass-cache>] [I<--reset>]

Let's expose the mutual exclusion in our man page, by using the {a|b} notation like we do on other commands:

=item B<dump> I<domain-id> I<corefilepath> [I<--bypass-cache>]
{[I<--live>] | [I<--crash>] | [I<--reset>]}

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]