[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] tests: Skip Xen-HVM tests for root on dom0

On 10/12/2011 02:11 AM, Philipp Hahn wrote:
Several tests fail when run as root on a Xen-dom0-system, since
virInitialize() then succeeds to open /proc/xen/privcmd and returns the
actual supported features instead of the faked one when calling
xenHypervisorMakeCapabilitiesInternal(). Since Xen-4.1 supports
additional features like "hap" and "viridian", the xencapstest fails.

I'm not sure I like this. I'd much rather fix things to avoid parsing live /proc/xen/privcmd when run from the testsuite, perhaps by providing a hook function that only the testsuite overrides (we've done this elsewhere). It is a bug if a testsuite ever depends on live system information, and skipping the test just papers over the real bug.

For now disable those 4 tests and return EXIT_AM_SKIP for them.

A better fix would probably just check for the minimum required features
instead of comparing the two XML documents for bit-equivalence.

Or better yet, fixing the test to parse hard-coded information captured in a tests/*data/... directory associated with the test rather than reading /proc/xen/privcmd in the first place.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]