[libvirt] [libvirt PATCHv3 01/10] support continue/return

Stefan Berger stefanb at linux.vnet.ibm.com
Wed Oct 12 20:46:31 UTC 2011


On 10/12/2011 03:50 PM, David L Stevens wrote:
> 	This patch adds support for "continue" and "return" actions
> in filter rules.
>
> Signed-off-by: David L Stevens<dlstevens at us.ibm.com>
> ---
>   src/conf/nwfilter_conf.c |    8 ++++++--
>   src/conf/nwfilter_conf.h |    2 ++
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
> index 08ede48..e0c2fb6 100644
> --- a/src/conf/nwfilter_conf.c
> +++ b/src/conf/nwfilter_conf.c
> @@ -55,12 +55,16 @@
>   VIR_ENUM_IMPL(virNWFilterRuleAction, VIR_NWFILTER_RULE_ACTION_LAST,
>                 "drop",
>                 "accept",
> -              "reject");
> +              "reject",
> +              "return",
> +              "continue");
>
>   VIR_ENUM_IMPL(virNWFilterJumpTarget, VIR_NWFILTER_RULE_ACTION_LAST,
>                 "DROP",
>                 "ACCEPT",
> -              "REJECT");
> +              "REJECT",
> +              "RETURN",
> +              "CONTINUE");
>
>   VIR_ENUM_IMPL(virNWFilterRuleDirection, VIR_NWFILTER_RULE_DIRECTION_LAST,
>                 "in",
> diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h
> index 5306403..c96851a 100644
> --- a/src/conf/nwfilter_conf.h
> +++ b/src/conf/nwfilter_conf.h
> @@ -299,6 +299,8 @@ enum virNWFilterRuleActionType {
>       VIR_NWFILTER_RULE_ACTION_DROP = 0,
>       VIR_NWFILTER_RULE_ACTION_ACCEPT,
>       VIR_NWFILTER_RULE_ACTION_REJECT,
> +    VIR_NWFILTER_RULE_ACTION_RETURN,
> +    VIR_NWFILTER_RULE_ACTION_CONTINUE,
>
>       VIR_NWFILTER_RULE_ACTION_LAST,
>   };
I'd ACK this. I'd like to also have test cases for the libvirt-tck.

    Stefan




More information about the libvir-list mailing list