[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Check for domain being active on successful job acquire



On 10/12/2011 05:59 AM, Michal Privoznik wrote:
As this is needed. Although some functions check for domain
being active before obtaining job, we need to check it after,
because obtaining job unlocks domain object, during which
a state of domain can be changed.
---
  src/qemu/qemu_driver.c |   75 ++++++++++++++++++++++++++++++++++++++++++++----
  1 files changed, 69 insertions(+), 6 deletions(-)

ACK. We've had patches like this in the past (commit 054d43f came to my mind).

It might be nicer to someday refactor the code to move the burden into the begin-job helper, instead of repeating it on all callers, but as that is a bigger patch, and would cause more merge conflicts across backports, I'm okay if it gets delayed until someone really has the time and motivation to tackle that project.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]