[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell



Hello,

I have a De-Ja-Vu:

On Thursday 13 October 2011 01:16:35 Eric Blake wrote:
> On 10/12/2011 04:39 PM, Guido Günther wrote:
> > Escape strings so they're safe to pass to the shell. Based on glib's
> > g_quote_string.

We already have a escape-for-shell function: please have a look at 
src/qemu/qemu_monitor.c:142 qemuMonitorEscapeShell()

But it works on "const char *" and returns "char *" instead of "virBuffer", so 
a merge with this new virBufferEscapeShell() is very much appreciated.

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      hahn univention de
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]