[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Fix occasional container creation failure due to misuse of grantpt



Quoting Eric Blake (eblake redhat com):
...
> of /dev/pts, then passing that fd back to the parent; the
> alternative solution would be to ditch glibc interfaces and do the
> raw ioctl calls on the master pty ourselves.  Since lxc is already
> Linux-specific, I think that I would favor this approach as being
> simpler (that is, completely ditch virFileOpenTtyAt, and teach lxc
> to just make the raw ioctl calls instead of using grantpt and
> unlockpt, all without forking or passing fds across a socket).
> 
> Serge, is this something you can attempt, or should I look into it more?

Hey Eric,

yup, if it's acceptable to you I think that's the better, simpler
approach.  I'll send out a new patch.

thanks,
-serge


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]