[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] macvtap: plug memory leak for 802.1Qbh





On 10/14/11 2:08 PM, "Eric Blake" <eblake redhat com> wrote:

> On 10/14/2011 03:05 PM, Roopa Prabhu wrote:
>>> I had already pushed mine.  Yours is missing a virReportOOMError() on
>>> allocation failure; but ACK with that improvement.
>>> 
>> Great. Thanks!. I will send out a patch for the bug fix and later work on
>> the fixing the error return convention.
> 
> I already pushed the bug fix in your name:
> 
> commit 80b077ee5ea0dd899b87d370f9fa892e727832f5
> Author: Roopa Prabhu <roprabhu cisco com>
> Date:   Fri Oct 14 13:41:46 2011 -0700
> 
>      macvtap: avoid invalid free
> 
>      Commit 0472f39 plugged a leak, but introduced another bug:
> 
>      Actually looks like physfndev is conditionally allocated in
> getPhysfnDev
>      Its better to modify getPhysfnDev to allocate physfndev every time.
> 
> so all that remains is cleaning up the error return convention.

Thanks eric.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]