[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 13/23] Remove GVirConfigObject::docHandle



On Tue, Oct 18, 2011 at 12:44:27PM +0100, Daniel P. Berrange wrote:
> > -    if (priv->docHandle)
> > -        xmlFreeDoc(priv->docHandle);
> > +    /* FIXME: all objects describing a given XML document will share the
> > +     * same document so we can't destroy it here like this, we need some
> > +     * refcounting to know when to destroy it.
> > +     */
> > +    if (priv->node)
> > +        xmlFreeDoc(priv->node->doc);
> 
> This could be reason for creating a trivial GObject to wrap
> the  xmlDocPtr instance, gaining ref counting.

Yes, that's the plan, and that's also why I mentioned this gupnp object in
one of the previous commits.

Christophe

Attachment: pgp9Yw1m7wBUK.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]