[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Fix name-space handling



On Tue, Oct 18, 2011 at 06:22:49PM +0200, Philipp Hahn wrote:
> The XML parser for the qemu specific extensions expects the qemu name-space
> to be bound to the 'qemu' prefix. This is too strict, since the name of the
> name-space-prefix is only mend as an internal lookup key. Only the associated
> URI is relevant.
> <domain>...
>   <qemu:commandline xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0";>
>   ...</qemu:commandline>
> </domain>
> 
> <domain xmlns:ns0="http://libvirt.org/schemas/domain/qemu/1.0";>...
>   <ns0:commandline>
>   ...</ns0:commandline>
> </domain>
> 
> <domain xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0";>
>   <qemu:commandline xmlns:qemu="urn:foo">
>   ...</qemu:commandline>
> </domain>
> 
> Remove the test for checking the name-space binding on the top-level <domain>
> element. Registering the name-space with XPath is enough.
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  src/qemu/qemu_domain.c |   30 ++++++++++++------------------
>  1 files changed, 12 insertions(+), 18 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]