[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Test name-space handling



On Tue, Oct 18, 2011 at 09:16:01PM +0200, Philipp Hahn wrote:
> Add test cases for parsing the qemu-name-space.
> This is based on qemuxml2argv{test,data/}, but can not reside in
> qemuxml2argv{test,data/} because ...
> 
> 1. qemuxmlns-qemu-ns-domain.xml is not schema-valid and breaks
> domainschematest. The test is still important to detect xmlns:qemu
> bindings to a name-space other than
> http://libvirt.org/schemas/domain/qemu/1.0
> 
> 2. they break qemuxml2xml, because the xmlns:qemu binding is moved to
> the top-level <domain> element when converting from argv to xml.
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  tests/Makefile.am                                  |   12 +-
>  .../qemuxmlns-qemu-ns-commandline-ns0.args         |    4 +
>  .../qemuxmlns-qemu-ns-commandline-ns0.xml          |   27 ++
>  .../qemuxmlns-qemu-ns-commandline-ns1.args         |    4 +
>  .../qemuxmlns-qemu-ns-commandline-ns1.xml          |   27 ++
>  .../qemuxmlns-qemu-ns-commandline.args             |    4 +
>  .../qemuxmlns-qemu-ns-commandline.xml              |   27 ++
>  .../qemuxmlns-qemu-ns-domain-commandline-ns0.args  |    4 +
>  .../qemuxmlns-qemu-ns-domain-commandline-ns0.xml   |   27 ++
>  .../qemuxmlns-qemu-ns-domain-commandline.args      |    4 +
>  .../qemuxmlns-qemu-ns-domain-commandline.xml       |   27 ++
>  .../qemuxmlns-qemu-ns-domain-ns0.args              |    4 +
>  .../qemuxmlnsdata/qemuxmlns-qemu-ns-domain-ns0.xml |   27 ++
>  tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain.args  |    4 +
>  tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain.xml   |   27 ++
>  tests/qemuxmlnstest.c                              |  290 ++++++++++++++++++++
>  16 files changed, 516 insertions(+), 3 deletions(-)
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline-ns0.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline-ns0.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline-ns1.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline-ns1.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-commandline.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-commandline-ns0.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-commandline-ns0.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-commandline.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-commandline.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-ns0.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-ns0.xml
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain.args
>  create mode 100644 tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain.xml
>  create mode 100644 tests/qemuxmlnstest.c

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]