[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt PATCH] support continue/return targets in nwfilter



On Tue, Oct 18, 2011 at 12:55:25PM -0700, David L Stevens wrote:
> 
> 
> 	This patch adds support for "continue" and "return" actions
> in filter rules.
> 
> Signed-off-by: David L Stevens <dlstevens us ibm com>
> 
> diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
> index 04bfa22..3e28806 100644
> --- a/src/conf/nwfilter_conf.c
> +++ b/src/conf/nwfilter_conf.c
> @@ -55,12 +55,16 @@
>  VIR_ENUM_IMPL(virNWFilterRuleAction, VIR_NWFILTER_RULE_ACTION_LAST,
>                "drop",
>                "accept",
> -              "reject");
> +              "reject",
> +              "return",
> +              "continue");
>  
>  VIR_ENUM_IMPL(virNWFilterJumpTarget, VIR_NWFILTER_RULE_ACTION_LAST,
>                "DROP",
>                "ACCEPT",
> -              "REJECT");
> +              "REJECT",
> +              "RETURN",
> +              "CONTINUE");
>  
>  VIR_ENUM_IMPL(virNWFilterRuleDirection, VIR_NWFILTER_RULE_DIRECTION_LAST,
>                "in",
> diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h
> index 5306403..c96851a 100644
> --- a/src/conf/nwfilter_conf.h
> +++ b/src/conf/nwfilter_conf.h
> @@ -299,6 +299,8 @@ enum virNWFilterRuleActionType {
>      VIR_NWFILTER_RULE_ACTION_DROP = 0,
>      VIR_NWFILTER_RULE_ACTION_ACCEPT,
>      VIR_NWFILTER_RULE_ACTION_REJECT,
> +    VIR_NWFILTER_RULE_ACTION_RETURN,
> +    VIR_NWFILTER_RULE_ACTION_CONTINUE,
>  
>      VIR_NWFILTER_RULE_ACTION_LAST,
>  };

ACK

Though it'd be good to update docs/nwfilter.html.in too to mention this

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]