[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] lxc: use our own hand-rolled code in place of unlockpt and grantpt (v2)



Quoting Eric Blake (eblake redhat com):
> >+        VIR_FORCE_CLOSE(*ttymaster);
> >+        VIR_FREE(*ttyName)
> 
> How did this ever pass compile-testing without that semicolon?

It didn't.  So I fixed it.  Then apparently did not do a new
git format-patch before sending.  Grr.

...

> ACK to the intent and to incorporating previous review comments.
> Here's what I squashed in before pushing:

Great, looks good, thanks.

-serge


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]