[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 1/4] conf: Introduce optional on_missing attribute for cdrom and floppy



On Wed, Oct 19, 2011 at 04:42:56PM +0200, Michal Privoznik wrote:
> This attribute says what to do with cdrom (or floppy) if
> the source is missing. It accepts:
> - mandatory - fail if missing for any reason (the default)
> - requisite - fail if missing on boot up, drop if missing on
>               migrate/restore/revert
> - optional  - drop if missing at any start attempt.

I find  'on_missing'  to be a bit of wierd attribute name
given the attribute values. Seeing it doesn't immediately
make it clear to me what it does.

If we're going to call it on_missing, then the attribute
values need some other kind of name

  on_missing='fail|continue|drop'


Or to keep these attribute names, I'd go for something like

  startPolicy="mandatory|requisite|optional";


If we resolve the naming decision, the patch looks fine

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]