[libvirt] [PATCHv2 09/13] snapshot: simplify indentation of network xml

Eric Blake eblake at redhat.com
Thu Oct 20 23:07:24 UTC 2011


On 10/20/2011 07:00 AM, Peter Krempa wrote:
> On 09/29/2011 06:22 PM, Eric Blake wrote:
>> More simplifications possible due to auto-indent. Also,
>> <bandwidth> within<actual> was only using 6 instead of 8 spaces.
>>

>> +++ b/src/util/network.h
>> @@ -1,7 +1,7 @@
>> /*
>> * network.h: network helper APIs for libvirt
>> *
>> - * Copyright (C) 2009-2009 Red Hat, Inc.
>> + * Copyright (C) 2009-2009, 2011 Red Hat, Inc.
>
> 2009-2009? Wouldn't it be better to state "2009, 20011"?

I didn't even notice the typo in the pre-patch version - I have an emacs 
file save hook that auto-updates these lines.  Fixed now.

>
> ACK,

Pushed.

Any review on 10-12 yet?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list