[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix error message on vol-create-from failure



Sorry, please ignore this. The title should be 'virsh: ' not 'storage: '.
I'll post another one soon.

  ozaki-r

On Mon, Oct 24, 2011 at 8:18 PM, Ryota Ozaki <ozaki ryota gmail com> wrote:
> If vol-create-from is failed due to 'input volume not found',
> virsh outputs like this:
>  $ sudo virsh vol-create-from testpool test-vol.xml test.img
>  error: failed to get vol 'test.img', specifying --pool might help
>  error: Storage volume not found: no storage vol with matching path
> However, '--pool' is incorrect because it is already specified as
> second argument ('testpool' in this case). It should be "--inputpool".
>
> The patch fixes this by using pooloptname, which will be "inputpool"
> in this case and "pool" in other cases, as error message.
> ---
>  tools/virsh.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 72344f0..5544a41 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -15216,8 +15216,8 @@ vshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd,
>         if (pool)
>             vshError(ctl, _("failed to get vol '%s'"), n);
>         else
> -            vshError(ctl, _("failed to get vol '%s', specifying --pool "
> -                            "might help"), n);
> +            vshError(ctl, _("failed to get vol '%s', specifying --%s "
> +                            "might help"), n, pooloptname);
>     }
>
>     if (pool)
> --
> 1.7.4.1
>
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]