[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Encode input file id in qemuDomainSave/Restore and qemudDomainCoreDump



On Tue, Oct 25, 2011 at 03:43:22PM +0800, Hong Xiang wrote:
> Base64 encode input file id in qemuDomainSaveFlags(),
> qemuDomainRestoreFlags(), qemuDomainSaveImageGetXMLDesc(),
> qemuDomainSaveImageDefineXML(), qemudDomainCoreDump(), and put generated
> files in controlled directories: qemu_driver->savedImageDir, and
> qemu_driver->coreDumpDir.
> 
> * src/qemu/qemu_conf.h: add 2 fields to struct qemud_driver
> * src/qemu/qemu_driver.c: base64 encoding file id and id->path translation
> 
> Signed-off-by: Hong Xiang <hxiang linux vnet ibm com>
> ---
>  src/qemu/qemu_conf.h   |    3 +
>  src/qemu/qemu_driver.c |   98 +++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 96 insertions(+), 5 deletions(-)

NACK, you can't change the semantics of existing APIs in
this way. It will break any applications using the APIs
already.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]