[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Remove virFileAbsPath() from virDomainSave*() and virDomainCoreDump() calls



On Tue, Oct 25, 2011 at 03:43:21PM +0800, Hong Xiang wrote:
> Change the semantics of '--file' parameter user provides in cmdline from a
> relative/absolute filesystem path to an id which is to be converted in
> driver to form a filesystem path.
> 
> * src/libvirt.c: remove virFileAbsPath() calls
> 
> Signed-off-by: Hong Xiang <hxiang linux vnet ibm com>
> ---
>  src/libvirt.c |   84 +++++----------------------------------------------------
>  1 files changed, 7 insertions(+), 77 deletions(-)

NACK, you can't change the semantics of existing APIs in
this way.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]