[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] New APIs to manage saved-state & core-dump files.



On Tue, Oct 25, 2011 at 03:44:36PM +0800, Hong Xiang wrote:
> New APIS:
> . virConnectNumOfSavedImages
> . virConnectListSavedImages
> . virSavedImageRemove
> . virSavedImageDownload
> . virConnectNumOfCoreDumps
> . virConnectListCoreDumps
> . virCoreDumpRemove
> . virCoreDumpDownload
> 
> * include/libvirt/libvirt.h.in: declarations
> * src/driver.h: driver extension for new APIs
> * src/libvirt.c, src/libvirt_public.syms: entry points for new APIs
> * python/generator.py,
>   python/libvirt-override-api.xml,
>   python/libvirt-override.c: overridden python binding
> 
> Signed-off-by: Hong Xiang <hxiang linux vnet ibm com>
> ---
>  include/libvirt/libvirt.h.in    |   18 +++
>  python/generator.py             |    2 +
>  python/libvirt-override-api.xml |   10 ++
>  python/libvirt-override.c       |   92 ++++++++++++
>  src/driver.h                    |   34 +++++
>  src/libvirt.c                   |  314 +++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms         |   12 ++
>  7 files changed, 482 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 361881a..6a2c4e4 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1084,6 +1084,15 @@ int             virDomainSaveImageDefineXML     (virConnectPtr conn,
>                                                   const char *file,
>                                                   const char *dxml,
>                                                   unsigned int flags);
> +int             virConnectNumOfSavedImages      (virConnectPtr conn);
> +int             virConnectListSavedImages       (virConnectPtr conn,
> +                                                 char **const files,
> +                                                 int maxfiles);
> +int             virSavedImageRemove             (virConnectPtr conn,
> +                                                 const char *file);
> +int             virSavedImageDownload           (virConnectPtr conn,
> +                                                 virStreamPtr stream,
> +                                                 const char *file);

THis looks very much like it is tending towards re-inventing most of the
existing snapshot and/or managed save functionality.

> @@ -1101,6 +1110,15 @@ int                    virDomainManagedSaveRemove(virDomainPtr dom,
>  int                     virDomainCoreDump       (virDomainPtr domain,
>                                                   const char *to,
>                                                   unsigned int flags);
> +int                     virConnectNumOfCoreDumps(virConnectPtr conn);
> +int                     virConnectListCoreDumps (virConnectPtr conn,
> +                                                 char **const files,
> +                                                 int maxfiles);
> +int                     virCoreDumpRemove       (virConnectPtr conn,
> +                                                 const char *file);
> +int                     virCoreDumpDownload     (virConnectPtr conn,
> +                                                 virStreamPtr stream,
> +                                                 const char *file);

This is slightly more palatable. IMHO we do want some kind of
'managed core dump' functionality to associate these APIs with,
since we can't change the semantics of the existing virDOmainCoreDump
API. ie we want something like

   virDomainManagedCoreDump(virDomainPtr dom, int flags);

and now libvirt will pick the core dump filename, probably based on
date.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]