[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] Add APIs for virNetSocket for sending/receiving file descriptors



On Mon, Oct 24, 2011 at 03:31:13PM -0600, Eric Blake wrote:
> On 10/21/2011 06:55 AM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange"<berrange redhat com>
> >
> >Add APIs to the virNetSocket object, to allow file descriptors
> >to be send/received over UNIX domain socket connections
> 


> >+        return -1;
> >+    }
> >+    virMutexLock(&sock->lock);
> >+
> >+    if ((ret = recvfd(sock->fd, 0))<  0) {
> 
> Should we s/0/O_CLOEXEC/ for flags, so the received socket has the
> cloexec bit already set?

Yep, might as well

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]