[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] startupPolicy: Change event argument



On Wed, Oct 26, 2011 at 12:26:51PM +0200, Michal Privoznik wrote:
> As this is on yet unreleased API this change is possible.
> This patch changes devAlias parameter in event callback to
> disk target as mgmt application is more likely to know target
> (it's required on domain definition) but aliases are generated
> by the daemon. So we can say this spares mgmt application at least
> one subsequent call of dumpxml on incoming event.

We already use 'devAlias' in the block I/O error event, so IMHO
it is good that we are consistent here too.  So I'd rather not
change what we have for media change events.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]