[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: avoid missing '{' in the function



On Thu, Oct 27, 2011 at 03:17:59PM +0800, ajia redhat com wrote:
> From: Alex Jia <ajia redhat com>
> 
> Cppcheck detected a syntaxError on lxcDomainInterfaceStats.
> 
> * src/lxc/lxc_driver.c: fixed missing '{' in the function lxcDomainInterfaceStats.
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  src/lxc/lxc_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index f08e8d1..06bfa85 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -2671,6 +2671,7 @@ static int
>  lxcDomainInterfaceStats(virDomainPtr dom,
>                          const char *path ATTRIBUTE_UNUSED,
>                          struct _virDomainInterfaceStats *stats ATTRIBUTE_UNUSED)
> +{
>      lxcError(VIR_ERR_NO_SUPPORT, "%s", __FUNCTION__);
>      return -1;
>  }

Hmm, I dunno why we even have a '#ifdef __linux__' in that file
since the entire file is Linux specific. We should just kill this
#else clause entirely


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]