[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: remove dummy function



On Thu, Oct 27, 2011 at 06:10:55PM +0800, ajia redhat com wrote:
> From: Alex Jia <ajia redhat com>
> 
> Cppcheck detected a syntaxError on lxcDomainInterfaceStats, my initial patch
> added a '{' to reserve 'else' branch to avoid a syntax error, in fact, don't
> need the dummy function in 'else' branch.
> 
> * src/lxc/lxc_driver.c: remove dummy function entirely.
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  src/lxc/lxc_driver.c |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index 06bfa85..251fa92 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -2666,15 +2666,6 @@ cleanup:
>          virDomainObjUnlock(vm);
>      return ret;
>  }
> -#else
> -static int
> -lxcDomainInterfaceStats(virDomainPtr dom,
> -                        const char *path ATTRIBUTE_UNUSED,
> -                        struct _virDomainInterfaceStats *stats ATTRIBUTE_UNUSED)
> -{
> -    lxcError(VIR_ERR_NO_SUPPORT, "%s", __FUNCTION__);
> -    return -1;
> -}
>  #endif
>  
>  static int lxcDomainGetAutostart(virDomainPtr dom,

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]