[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt PATCHv4 1/2] add DHCP snooping



David Stevens/Beaverton/IBM wrote on 10/26/2011 06:51:26 PM:


> Stefan Berger <stefanb linux vnet ibm com> wrote on 10/26/2011 11:32:25 AM:
>


>
> > Also, in case learning is NULL, you may need to set it to 'any' (for
> > backwards-compatibility) to avoid a NULL pointer crash later on.

>
> I didn't try it with NULL -- if it is not set (ie, the variable is not

> present at all), it defaults to "any" already. If it's set to garbage,

That was not the behavior I had encountered. I forgot to put the ip_learning into
the collection of variables and then learning ended up being NULL, which then crashed it.


> I did have some issues with restarting libvirtd (primarily VM's exiting when

> I restarted multiple times), but those were there before I applied any of
> these patches; no log messages when that happened.

By the way, also try the 'kill -SIGHUP `pidof libvirtd`' to have the filters rebuilt.
It's similar to a restart of libvirtd.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]