[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] Make rewriting XML files more robust



On Wed, Oct 19, 2011 at 19:26:23 +0200, Jiri Denemark wrote:
> Jiri Denemark (4):
>   Introduce virFileSync
>   Introduce virFileRewrite for safe file rewrite
>   Introduce virXMLSaveFile as a wrapper for virFileRewrite
>   Use virXMLSaveFile when writing XML config
> 
>  src/conf/domain_conf.c   |   32 +-------------------
>  src/conf/network_conf.c  |   34 +--------------------
>  src/conf/nwfilter_conf.c |   68 ++----------------------------------------
>  src/conf/storage_conf.c  |   37 ++---------------------
>  src/libvirt_private.syms |    3 ++
>  src/qemu/qemu_domain.c   |   19 +-----------
>  src/util/util.c          |    4 ++-
>  src/util/virfile.c       |   72 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virfile.h       |    8 +++++
>  src/util/xml.c           |   36 +++++++++++++++++++++++
>  src/util/xml.h           |    5 +++
>  11 files changed, 141 insertions(+), 177 deletions(-)

I dropped patch 1, replaced virFileSync with fsync in patch 2, moved hunks
touching domain_conf.c from patch 3 to patch 4, renamed the structure in patch
3 as suggested by Daniel, and pushed the result.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]