[libvirt] [PATCH 2/2] V2 Modify generic ethernet interface so it will work when sVirt is enabled with qemu

Eric Blake eblake at redhat.com
Fri Oct 28 03:25:57 UTC 2011


On 10/24/2011 05:44 PM, Tyler Coumbes wrote:
> This patch makes the changes to the generic ethernet interface for
> QEMU. Allowing it to be used with sVirt enabled.
>
>   src/qemu/qemu_command.c |   79 ++++++++++++++++++++++++++++++++++++++++++++--
>   src/qemu/qemu_command.h |    4 ++
>   src/qemu/qemu_hotplug.c |   15 +++++++++
>   src/qemu/qemu_process.c |   13 ++++++++
>   4 files changed, 107 insertions(+), 4 deletions(-)

I haven't reviewed this one closely yet, but it would help if you added 
a test in tests/qemuxml2argvtest.c and a new pair of files in 
tests/qemuxml2argvdata/* that exercise the code to prove the new command 
line options look sane.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list