[libvirt] [PATCH] qemu: plug memory leak
Eric Blake
eblake at redhat.com
Mon Oct 31 17:16:05 UTC 2011
On 10/29/2011 11:12 AM, ajia at redhat.com wrote:
> From: Alex Jia<ajia at redhat.com>
>
> Detected by Coverity. Leak introduced in commit 6cabc0b.
>
> * src/qemu/qemu_command.c: Clean up on failure.
>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---
> src/qemu/qemu_command.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 0936492..02958cb 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -4995,6 +4995,7 @@ qemuBuildCommandLine(virConnectPtr conn,
> }
>
> if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) {
> + VIR_FREE(modstr);
> qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> _("this QEMU binary lacks hda support"));
> goto error;
ACK and pushed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list