[libvirt] [PATCH] remote: Fix incorrect error codes

Osier Yang jyang at redhat.com
Thu Sep 1 07:17:08 UTC 2011


Introduced by d4b53ef6c. For "no internalFlags support", the
error code is changed into INTERNAL_ERROR.
---
 src/remote/remote_driver.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 603d589..79fcac0 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2936,7 +2936,7 @@ static int remoteDomainEventRegister(virConnectPtr conn,
     remoteDriverLock(priv);
 
     if (priv->domainEventState->timer < 0) {
-         remoteError(VIR_ERR_OPERATION_INVALID, "%s", _("no event support"));
+         remoteError(VIR_ERR_NO_SUPPORT, "%s", _("no event support"));
          goto done;
     }
 
@@ -3285,7 +3285,7 @@ remoteSecretGetValue (virSecretPtr secret, size_t *value_size,
 
     /* internalFlags intentionally do not go over the wire */
     if (internalFlags) {
-        remoteError(VIR_ERR_OPERATION_INVALID, "%s", _("no internalFlags support"));
+        remoteError(VIR_ERR_INTERNAL_ERROR, "%s", _("no internalFlags support"));
         goto done;
     }
 
@@ -3549,7 +3549,7 @@ static int remoteDomainEventRegisterAny(virConnectPtr conn,
     remoteDriverLock(priv);
 
     if (priv->domainEventState->timer < 0) {
-         remoteError(VIR_ERR_OPERATION_INVALID, "%s", _("no event support"));
+         remoteError(VIR_ERR_NO_SUPPORT, "%s", _("no event support"));
          goto done;
     }
 
-- 
1.7.6




More information about the libvir-list mailing list