[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: Fix incorrect changes on error codes.



On Thu, Sep 01, 2011 at 02:28:12PM +0800, Osier Yang wrote:
> Fix incorrect changes introduced by commit 6ac47762bb9.
> ---
>  src/lxc/lxc_driver.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index 5587b06..6b716c1 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -1786,7 +1786,7 @@ lxcDomainCreateAndStart(virConnectPtr conn,
>          goto cleanup;
>  
>      if ((def->nets != NULL) && !(driver->have_netns)) {
> -        lxcError(VIR_ERR_OPERATION_INVALID,
> +        lxcError(VIR_ERR_CONFIG_UNSUPPORTED,
>                   "%s", _("System lacks NETNS support"));
>          goto cleanup;
>      }
> @@ -2519,8 +2519,7 @@ static int
>  lxcDomainInterfaceStats(virDomainPtr dom,
>                          const char *path ATTRIBUTE_UNUSED,
>                          struct _virDomainInterfaceStats *stats ATTRIBUTE_UNUSED)
> -    lxcError(VIR_ERR_OPERATION_INVALID, "%s",
> -             _("interface stats not implemented on this platform"));
> +    lxcError(VIR_ERR_NO_SUPPORT, "%s", __FUNCTION__);
>      return -1;
>  }
>  #endif

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]