[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v2 04/13] Add a new controller type 'usb' with optionnal 'model'



On Fri, Aug 26, 2011 at 01:44:20AM +0300, Marc-André Lureau wrote:
> The model by default is piix3-uchi.
> 
> Example:
> <controller type='usb' index='0' model='ich9-ehci'/>

> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index dbfc7d9..2f32e37 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -83,6 +83,30 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST,
>                "", /* don't support vbox */
>                "qxl");
>  
> +VIR_ENUM_DECL(qemuControllerModelSCSI)
> +
> +VIR_ENUM_IMPL(qemuControllerModelSCSI, VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LAST,
> +              "", /* auto */
> +              "", /* buslogic don't support */
> +              "", /* lsilogic don't support */
> +              "", /* lsisas don't support */
> +              "", /* vmpvscsi don't support */
> +              );

I don't see this enum used anywhere, so I think you can just leave it
out entirely.

ACK aside from that bit

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]