[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Increase size of buffer for xend response



Eric Blake wrote:
> On 09/01/2011 06:36 PM, Jim Fehlig wrote:
>> On systems with many pcpus, the sexpr returned by xend can be quite
>> large for dom0 when it is configured to have #vcpus = #pcpus (default).
>> E.g. on a 80 pcpu system, where dom0 had 80 vcpus, the sexpr details
>> for dom0 was 73817 bytes!  Increase maximum buffer size to 256k.
>> ---
>>   src/xen/xend_internal.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
>> index 957cd17..1fdebe1 100644
>> --- a/src/xen/xend_internal.c
>> +++ b/src/xen/xend_internal.c
>> @@ -56,7 +56,7 @@
>>    * The number of Xen scheduler parameters
>>    */
>>
>> -#define XEND_RCV_BUF_MAX_LEN 65536
>> +#define XEND_RCV_BUF_MAX_LEN 262144
>
> I'd write this as:
>
> #define XEND_RCV_BUF_MAX_LEN (256 * 1024)
>
> for a bit more legibility.  ACK with that change.

Changed as suggested and pushed.  Thanks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]