[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v3 11/14] qemu: Don't append 0 at usb id, so that it is compatible with legacy -usb



On Fri, Sep 02, 2011 at 03:18:21AM +0200, Marc-André Lureau wrote:
> QEMU uses USB bus name "usb.0" when using the legacy -usb argument.
> If we want to allow USB devices to specify their addresses with legacy
> -usb, we should either in case of legacy bus name drop the 0 from the
> address bus, or just drop the 0 from device id. This patch does the
> later.
> 
> Another solution would be to permit addressing on non-legacy USB
> controllers only.
> ---
>  src/qemu/qemu_command.c                            |   46 +++++++++++++++-----
>  .../qemuxml2argv-input-usbmouse-addr.args          |    2 +-
>  .../qemuxml2argv-usb-ich9-companion.args           |    8 ++--
>  .../qemuxml2argv-usb-ich9-ehci-addr.args           |    2 +-
>  .../qemuxml2argv-usb-piix3-controller.args         |    2 +-
>  tests/qemuxml2argvtest.c                           |    2 +-
>  6 files changed, 43 insertions(+), 19 deletions(-)

  Of course I had to fix in the other way the 2 files
qemuxml2argvdata/qemuxml2argv-usb-hub.args
and
qemuxml2argvdata/qemuxml2argv-usb-ports.args

  I had modified previous to pass make check,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]