[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix localtime handling for Xen-PV domains



On Mon, Aug 15, 2011 at 07:52:20PM +0200, Philipp Hahn wrote:
> At least Xen-3.4.3 translates the /vm/localtime SXPR value to
> /domain/platform/localtime and /domain/image/{linux,hvm}/localtime when
> the domain is defined.  When reading back that information libvirt only
> handles HVM domains, but not PV domains: This results in libvirtd always
> returning
> 	<clock offset="utc"/>
> while Xend used (localtime 1).
> 
> For PV domains use /domain/image/linux/localtime.
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
> This is tracked at <https://forge.univention.org/bugzilla/show_bug.cgi?id=22321>
> ---
>  src/xenxs/xen_sxpr.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c
> index 1f5be5f..ff8326f 100644
> --- a/src/xenxs/xen_sxpr.c
> +++ b/src/xenxs/xen_sxpr.c
> @@ -1195,6 +1195,9 @@ xenParseSxpr(const struct sexpr *root,
>              def->clock.ntimers = 1;
>              def->clock.timers[0] = timer;
>          }
> +    } else { /* !hvm */
> +        if (sexpr_int(root, "domain/image/linux/localtime"))
> +            def->clock.offset = VIR_DOMAIN_CLOCK_OFFSET_LOCALTIME;
>      }
>  
>      /* Current XenD allows localtime here, for PV and HVM */

  Sounds reasonnable :-) ACK

   pushed, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]