[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] XML: Suppress printing "domain.xml" for parse errors on XML strings

Dňa 6.9.2011 9:41, Daniel Veillard wrote / napísal(a):
On Mon, Sep 05, 2011 at 02:33:40PM +0200, Peter Krempa wrote:
Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefore to print an error message not containing bogus filename

NULL is a valid parameter for the file name value, as the only usage is
for error handlers. Functions touching the value either in libxml2 or in
libvirt check this parameter for NULL and behave according to it.
  Well, I started that trend, and used that as a hint about what kind
of XML paring might be failing. If you have a better idea on how to
name that temporary "file" (it's actually a memory entity), but I'm
not sure setting it as NULL is such an improvement,


The idea of this patch was to suppress printing domain.xml in the error message and stick with the default error message which stated only the line number and was used
previously (it did not contain the filename).

I'll have another look at this and try to come up with something more descriptitve, if
it's possible.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]