[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] virsh: Add more human-friendly output of domblkstat command



On Mon, Sep 05, 2011 at 05:46:39PM +0200, Peter Krempa wrote:
> Users of virsh complain that output of the domblkstat command
> is not intuitive enough. This patch adds explanation of fields
> returned by this command to the help section for domblkstat and
> the man page of virsh. Also a switch --human is added for
> domblkstat that prints the fields with more descriptive texts.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=731656
> 
> Changes to v1:
> -Rebased to current head

  Sounds good ... but in the meantime that command changed to us the
more complex API virDomainBlockStatsFlags which can return even more
values (and potentially fallback to the old one. So I think this patch
need to be updated to the new version of that function. The current
patch can be used nearly as-is for the fallback case, but really --human
should document the new fields, check with Osier :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]