[libvirt] [PATCH v2] xml: Change virtual file names of xml documents parsed in memory

[Eric Blake]

On 09/08/2011 02:25 PM, Peter Krempa wrote:
> While parsing XML strings from memory, the previous convention in
> libvirt was to set the virtual file name to "domain.xml" or something
> similar. This could potentialy trick the user into looking for a file
> named domain.xml on the disk in an attempt to fix the error.
>
> This patch changes these filenames to something that can't be as easily
> confused for a valid filename.
>
> Examples of error messages:
> ---------------------------
> Error while loading file from disk:
>
> 15:07:59.015: 527: error : catchXMLError:709 : /path/to/domain.xml:1: StartTag: invalid element name
> <domain type='kvm'><
> --------------------^
>
> Error while parsing definintion in memory:
>
> 15:08:43.581: 525: error : catchXMLError:709 : (domain definition):2: error parsing attribute name
>    <name>vm1</name>
> --^

I like it.  ACK, and worth pushing pre-release.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org